-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error messages can't be copied #7115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fan of the design.
Here is an alternative suggestion: the AccordionSummary has a fixed title (like "Error Stack") in your PR, and the AccordionDetails contains both the error (in bold) and the error stack.
It should make it copyable, no?
The thing with this idea is that you are showing an error and there is no actual error to display, until the user interacts with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer that solution!
Note that we've adopted another solution in next
(see 19d7a69), but I think your solution is better and should be backported.
Fixes #6749
Before;
After: