Add ApolloError in error body when handling errors #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hlubek is attempting to deploy a commit to the Marmelab Team on Vercel. A member of the Team first needs to authorize it. |
hlubek
commented
Dec 7, 2021
| @@ -221,15 +221,14 @@ export default async (options: Options): Promise<DataProvider> => { | |||
| }; | |||
|
|
|||
| const handleError = (error: ApolloError) => { | |||
| console.error({ error }); | |||
There was a problem hiding this comment.
I think this console.error should not be here. Since handleError re-throws, it should be logged / catched at higher levels.
|
Thanks for your contribution! |
WiXSL
approved these changes
Jan 27, 2022
fzaninotto
approved these changes
Jan 28, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6953
I added a test to check for correct error handling when executing a mutation.