Skip to content

Migrate to react-hook-form #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 59 commits into from
Closed

Migrate to react-hook-form #6730

wants to merge 59 commits into from

Conversation

@djhi
Copy link
Collaborator

@djhi djhi commented Oct 28, 2021 •
edited
Loading

  • Migration of form & input components
  • Fix tests that uses react-final-form
  • Fix or remove e2e tests
  • Restore form level validation
  • Investigate ArrayInput default value support
  • Investigate ArrayInput validation support
  • Investigate if we should and can still provide FormDataConsumer
  • Fix RichTextInput validation
  • Fix default values on FilterForm
  • Fix FileInput
  • Fix warnings about controlled/uncontrolled inputs

@djhi djhi added the WIP Work In Progress label Oct 28, 2021
Travis CI and others added 28 commits October 28, 2021 15:47
Fix create page title
344fa79
Set validation on change
47ead36
Ensure we display errors on submit even when the field isn't touched
68a5d30
Ensure RichTextInput set its touched state to true correctly
a64bc75
Fix or skip some e2e tests related to create
a7efa8e
Fix SelectInput props type
8c48829
Fix AutocompleteArrayInput onFocus call
a81e39f
Fix cypress e2e tests for edit
a548857
Validate on submit by default (like react-hook-form)
5c19665
Fix SelectInput create support
da0a281
Ensure useInput allows previously registered input (references)
5f5b1aa
Migrate quick create example to new mechanism
b0fcf10
Bypass ra-no-code for now
bf688da
@djhi
Fix FilterForm initial values
b4494a4
@djhi
Allows to configure react-hook-form
6eb2712
@djhi
Fix cypress configuration
c5e3203
@djhi
Fix inputs props type
e9a3823
@djhi
Better support for hmr in RichTextInput
af9f167
@djhi
Migrate to react-hook-form form level validation
41f0f06
@djhi
Move from form level validation to field level validation in PostCreate
681b3ab
@djhi
Fix validation revalidate
e2cffb1
@djhi
Restore access to all form value in validators
53b8be6
@djhi
Update Upgrade Guide
d2d149c
@djhi
Upgrade testing-library and introduce userevents
cbef14e
@djhi
Fix several unit tests
4c44ee1
@djhi
Fix useWarnWhenUnsavedChanges
1b7e58b
@djhi
Fix linter warning
c000aff
Fix more tests
9da6866
djhi and others added 25 commits November 2, 2021 15:07
@djhi
Refactor for readability
8d6ae95
@djhi
Fix more tests
0eb9092
Fix DateInput tests
0a1fe17
Fix SelectInput tests
1f2b576
Fix NullableBooleanInput tests
23ccf0e
Fix ReferenceArrayInputController tests
c1a4823
Cleanup
f08aecd
Fix FileInput tests
c8026a2
Fix ImageInput tests
541f13a
Fix RadioButtonGroupInput tests
2da87b3
Fix BooleanInput tests
b3c1889
Fix CheckboxGroupInput tests
80e45cc
Fix NumberInput tests
1632240
Fix DateTimeInput tests
20970a1
Fix RichTextInput tests
9749eab
Fix FormTab tests
1656710
Fix SelectArrayInput tests
52843c7
Fix AutocompleteArrayInput tests
dc44e7b
@djhi
Fix AutocompleteInput tests
ccabc79
@djhi
Fix SaveButton tests
fb517c0
@djhi
Fix ArrayInput tests
a0a0267
@djhi
Fix ReferenceArrayInput tests
f58226b
@djhi
Fix remaining tests
1eab151
@djhi
Upgrade dropzone & fix FileInput
4837e9d
Restore ArrayInput defaultValue support
3b357fe
@fzaninotto fzaninotto mentioned this pull request Nov 24, 2021
Closed
@fzaninotto fzaninotto mentioned this pull request Dec 15, 2021
Closed
@djhi djhi closed this Jan 14, 2022
@djhi
Copy link
Collaborator Author

djhi commented Jan 14, 2022

I will start a new PR after #7072 is merged

@fzaninotto fzaninotto mentioned this pull request Jan 16, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

Assignees

No one assigned

Labels

WIP Work In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@djhi @fzaninotto