Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete buttons props types #6472

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Fix delete buttons props types #6472

merged 2 commits into from
Jul 29, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 28, 2021

Both buttons don't need the undoable prop

@djhi djhi added the RFR Ready For Review label Jul 28, 2021
@djhi djhi added this to the 3.17.1 milestone Jul 28, 2021
@WiXSL
Copy link
Contributor

WiXSL commented Jul 28, 2021 •
edited
Loading

@djhi I could do this can of maintenance for the rest of the components if you want
Let me know.

I mean removing FC definition

@djhi
Copy link
Collaborator Author

djhi commented Jul 28, 2021

@WiXSL That wasn't the point of the PR. I just do it whenever I edit a file which still uses FC. However, if you have the courage to do so, be my guest!

@fzaninotto fzaninotto merged commit 2f7c458 into master Jul 29, 2021
@fzaninotto fzaninotto deleted the fix-delete-buttons-types branch July 29, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.17.1
Development

Successfully merging this pull request may close these issues.
3 participants
@djhi @WiXSL @fzaninotto