Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useReferenceInputController sorting #5527

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Fix useReferenceInputController sorting #5527

merged 3 commits into from
Nov 13, 2020

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Nov 13, 2020

Fixes #5526

@djhi djhi added this to the 3.10.1 milestone Nov 13, 2020
@djhi djhi requested a review from fzaninotto November 13, 2020 09:22
fzaninotto
fzaninotto requested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the warning raised by the linter, I'm OK with these changes

@fzaninotto fzaninotto merged commit e221bb9 into master Nov 13, 2020
@fzaninotto fzaninotto deleted the fix-reference-input-sort branch November 13, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

ReferenceInput returned choices are not being sorted by sort field property
2 participants
@djhi @fzaninotto