Introduce Resource Context #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Nov 2, 2020
| const controllerProps = useReferenceArrayFieldController({ | ||
| resource, |
There was a problem hiding this comment.
why doesn't the useReferenceArrayFieldController call the useResourceContext itself?
| const controllerProps = useReferenceManyFieldController({ | ||
| page, | ||
| perPage, | ||
| resource, |
| return children(useReferenceInputController(props)) as ReactElement; | ||
| const { resource } = useResourceContext(props); | ||
| return children( | ||
| useReferenceInputController({ resource, ...props }) |
| @@ -23,6 +23,7 @@ import { | |||
| Record, | |||
| Exporter, | |||
| } from '../types'; | |||
| import { useResourceContext, useResourceDefinition } from '../core'; | |||
| * Must be used within a <ResourceContextProvider> (e.g. as a descendent of <Resource> | ||
| * or any reference related components). | ||
| * | ||
| * @returns {ResourceContextValue} The resource informations |
There was a problem hiding this comment.
Suggested change
| * @returns {ResourceContextValue} The resource informations | |
| * @returns {ResourceContextValue} The resource information |
| import { ResourceContext, ResourceContextValue } from './ResourceContext'; | ||
|
|
||
| /** | ||
| * Hook to read the resource informations from the ResourceContext. |
There was a problem hiding this comment.
Suggested change
| * Hook to read the resource informations from the ResourceContext. | |
| * Hook to read the resource information from the ResourceContext. |
| redirect = 'list', | ||
| onSuccess, | ||
| onFailure, | ||
| ...rest | ||
| } = props; | ||
| const translate = useTranslate(); | ||
| const classes = useStyles(props); | ||
| const { resource } = useResourceContext(props); |
| @@ -31,6 +31,7 @@ const DeleteWithUndoButton: FC<DeleteWithUndoButtonProps> = props => { | |||
| ...rest | |||
| } = props; | |||
| const classes = useStyles(props); | |||
| const { resource } = useResourceContext(props); | |||
djhi
force-pushed
the
resource-context-2
branch
from
ce33ab8
to
99f79a0
Compare
fzaninotto
approved these changes
Nov 3, 2020
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5446