Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several eslint warnings #5433

Merged
merged 3 commits into from
Oct 23, 2020
Merged

Fix several eslint warnings #5433

merged 3 commits into from
Oct 23, 2020

Conversation

Luwangel
Copy link
Contributor

By reading Travis's logs, I saw some warnings. So I'm correcting them.

/home/travis/build/marmelab/react-admin/packages/ra-ui-materialui/src/field/ReferenceField.tsx
  181:13  warning  The attribute aria-errormessage is not supported by the role presentation  jsx-a11y/role-supports-aria-props

Todo

  • Fix warnings in ReferenceField.tsx
  • Fix warnings in Query.spec.tsx

@Luwangel Luwangel added the RFR Ready For Review label Oct 22, 2020
@Luwangel Luwangel added this to the 3.9.5 milestone Oct 23, 2020
@Luwangel Luwangel merged commit 8fdff88 into master Oct 23, 2020
@Luwangel Luwangel deleted the fix-eslint-warnings branch October 23, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.9.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Luwangel @fzaninotto @djhi