Introduce useUpdateController
#10924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
reviewed
Sep 12, 2025
packages/ra-ui-materialui/src/button/UpdateWithConfirmButton.tsx
Outdated
Show resolved
Hide resolved
1 task
slax57
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Just like the
<DeleteButton>we want a controller hook that ease the implementation of<UpdateButton>in custom UIs.Solution
Introduce
useUpdateControllerHow To Test
<UpdateButton>should work as beforeAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature- [ ] The PR includes unit tests (if not possible, describe why)we decided to not invest more in tests as we already have some for the existing buttons.- [ ] The PR includes one or several stories (if not possible, describe why)Same- [ ] The documentation is up to dateSameAlso, please make sure to read the contributing guidelines.