Move more primitives from ra-ui-materialui to ra-core
#10907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
changed the title
ra-ui-materialui to ra-core
fzaninotto
reviewed
Aug 29, 2025
| * @deprecated Import from `ra-core` or `react-admin` instead | ||
| */ | ||
| export { ArrayInputContext, useArrayInput } from 'ra-core'; | ||
| export { |
There was a problem hiding this comment.
all ra-core is already re-exported by react-admin, aren't these hooks going to be exported twice?
There was a problem hiding this comment.
That's what we did in #10873. Should I revert it too? I think you're right but strangely enough, TS didn't complain at build time
There was a problem hiding this comment.
However, not re-exporting from ra-ui-materialui would be a breaking change for people importing from it instead of react-admin
slax57
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are still hooks and components that could be in
ra-corebut are inra-ui-materialui. We had to duplicate them inshadcn-admin-kitSolution
ra-coreHow To Test
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature- [ ] The PR includes unit tests (if not possible, describe why)no real logic- [ ] The PR includes one or several stories (if not possible, describe why)just contexts and consuming hooks