Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
<SimpleShowLayout>
uses child inspection to decorate its children with labels.This isn't robust, as you just need to wrap a child component to break this decoration:
Solution
Invert the responsibilities : it's no longer the layout's role to add a label, but the field's.
Provide a new component to render a field and its label,
RecordField
:How To Test
Use the fields/RecordField story
Additional Checks
master
for a bugfix or a documentation fix, ornext
for a feature