Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Add missing parameter to add function type of <SimpleFormIteratorContextValue> #10359

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Aikain
Copy link
Contributor

@Aikain Aikain commented Nov 18, 2024

Fix #10355

Problem

Wrong add-function type.

Solution

Add missing parameter.

There seems to be no mention in the documentation that a function can be given a parameter. However, I'm not able to produce good enough English to put it in the documentation so I didn't try to add it.

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why) (This is just change of type)
  • The PR includes one or several stories (if not possible, describe why) (This is just change of type)
  • The documentation is up to date

@djhi djhi changed the title Add missing parameter to add-function type of impleFormIteratorContextValue [TS] Add missing parameter to add function type of <SimpleFormIteratorContextValue> Nov 18, 2024
@djhi djhi changed the title [TS] Add missing parameter to add function type of <SimpleFormIteratorContextValue> [TypeScript] Add missing parameter to add function type of <SimpleFormIteratorContextValue> Nov 18, 2024
@slax57 slax57 added this to the 5.3.5 milestone Nov 19, 2024
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 merged commit c0012c7 into marmelab:master Nov 19, 2024
14 checks passed
@djhi djhi modified the milestones: 5.3.5, 5.4.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleFormIteratorContextValue: Missing parameters for the Add function type
3 participants