-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update Admin and Routing docs to encourage using a Data Router #10220
Conversation
Thanks for your PR. The current doc mention a way to use a regular router, and it works. It is true that if you want to use an data router, the doc needs to be updated. But I'm not sure that replacing the doc with the data router version is the best thing to do, as the setup is a bit more complicate din this case. Any second opinion on that? |
@fzaninotto Using a regular router works, sure, except regarding the Hence, I would agree with @smeng9 that it's best to encourage using a data router as soon as possible in the docs, to minimize the chances of users running into the issue of the non-working |
You've convinced me! Let's merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Problem
Current docs is outdated, does not work data APIs
React-router recommends user to update to use new API.
Solution
We should let user use
warnWhenUnsavedChanges
when they perform their setup with latest best practiceHow To Test
Describe the steps required to test the changes
Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.