Reject promise in checkError with logoutUser: false and without redirectTo causes an error #10172

[rktamil]

Add null check for redirect and When redirect is not provided, I returned false and let the called handles the redirect.

This may not be ideal solution, happy to discuss as this is my my first contribution.

Fixes #10172

[djhi]

Hi, thanks for contributing. Can you please first explain the issue?

[rktamil]

Hi , As per understanding this issue is caused when redirect is null for some use cases they don't want to redirect but using this to display an error message.

…

On Mon, Sep 2, 2024, 8:58 AM Gildas Garcia ***@***.***> wrote: Hi, thanks for contributing. Can you please first explain the issue? — Reply to this email directly, view it on GitHub <#10177 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEO463T6UPCA3YI4OJWNHX3ZURVIHAVCNFSM6AAAAABNOKDW3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUHAZDGNBUGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[slax57]

Your solution seems good to me, but it would be nice if you could prove it works by adding automated tests. Can you please add one?

[slax57]

I wonder if we should rather return true here, since logout was explicitly not requested, and I'm afraid this will throw another error in this code:

react-admin/packages/ra-core/src/dataProvider/useDataProvider.ts

Lines 124 to 136 in f67649d

	return logoutIfAccessDenied(error).then(
	loggedOut => {
	if (loggedOut)
	return {
	data: arrayReturnTypes.includes(
	type
	)
	? []
	: {},
	};
	throw error;
	}
	);