This repository was archived by the owner on Apr 17, 2019. It is now read-only.
[RFR] Minimax algorithm return a valid solution #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienMattiussi
changed the title
Luwangel
suggested changes
Jul 24, 2018
src/quarto/ai/basic.go
Outdated
| return piecesListNonWinning.([]int) | ||
| } | ||
| return loosingBoxList.([]grid.Point) | ||
| } |
There was a problem hiding this comment.
You should have a rule in vscode to add automatically an empty line at the end of each file.
| node.Childs = append(node.Childs, AppendChildNodes(childNode, depth-1, quit)) | ||
| } else { | ||
| for i := 0; i < len(boxList); i++ { | ||
| if len(piecesList) > 1 && len(boxList) > 1 { |
There was a problem hiding this comment.
You should split the code into small functions because it's not so readable. And in addition you could test small part of code.
src/quarto/game/game.go
Outdated
| // PlayTurn return the next move for given grid | ||
| func PlayTurn(currentState state.State) state.State { | ||
| newState, done := ai.StartMiniMax(currentState, 0) | ||
| newState, done := ai.StartMiniMax(currentState, 30) |
There was a problem hiding this comment.
You could have a constant
| return bestState | ||
| } | ||
|
|
||
| func CalculateNodeValue(node StateNode) int { |
There was a problem hiding this comment.
I don't like this function but I don't find a prettier version ^^
There was a problem hiding this comment.
Actually, the same ...
Luwangel
reviewed
Jul 26, 2018
src/quarto/ai/minimax.go
Outdated
| childNode.Value = LoosingLeafValue | ||
| } | ||
| return append(currentNode.Childs, childNode) | ||
| } else { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/ty1OGS7T
Full algorithm is done
I have not won against computer since this. (draws sometimes)