Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQL 16 compatibility #177

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix GraphQL 16 compatibility #177

merged 4 commits into from
Jul 31, 2024

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jul 25, 2024

How to test

  1. make install build
  2. npm pack
  3. create a directory next to json-graphql-server and cd into it
  4. yarn install ../json-graphql-server/json-graphql-server-3.0.0.tgz
  5. yarn json-graphql-server

You should have a running server at http://localhost:3000 that return a graphiql interface when accessed from a browser

@djhi djhi added the RFR Ready For Review label Jul 25, 2024
@djhi djhi added WIP and removed RFR Ready For Review labels Jul 25, 2024
@jaa134
Copy link
Contributor

jaa134 commented Jul 25, 2024

Thank you for this! Any idea when this will be merged and released?

@djhi djhi added RFR Ready For Review and removed WIP labels Jul 26, 2024
@djhi djhi requested a review from fzaninotto July 26, 2024 07:53
@jaa134
Copy link
Contributor

jaa134 commented Jul 29, 2024

@djhi The README mentions express-graphql. You might want to update that section!

The json-graphql-server accepts queries in GET and POST. Under the hood, it uses [the express-graphql module](https://github.com/graphql/express-graphql). Please refer to their documentations for details about passing variables, etc.

@djhi djhi added this to the 3.1.0 milestone Jul 31, 2024
@djhi djhi merged commit 860ab27 into master Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants