update zig path link even if it's lower priority in PATH#83
Merged
marler8997 merged 1 commit intomasterfrom Feb 23, 2023
Merged
update zig path link even if it's lower priority in PATH#83marler8997 merged 1 commit intomasterfrom
marler8997 merged 1 commit intomasterfrom
Conversation
marler8997
force-pushed
the
updateLinkEvenIfLowerPriority
branch
from
481c8f4 to
7ace347
Compare
marler8997
force-pushed
the
updateLinkEvenIfLowerPriority
branch
from
7ace347 to
a16b61e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's reasonable to update the path link even if the path link is not in the highest priority. I would however still consider this an "error" rather than a warning since the user is explicitly asking the tool to set the default compiler. The user can download compilers without asking zigup to set the default by using the "fetch" command.