Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added *_projectile equipment mapping for grenades #187

Merged
merged 1 commit into from
Feb 24, 2020
Merged

added *_projectile equipment mapping for grenades #187

merged 1 commit into from
Feb 24, 2020

Conversation

BestAwperEver
Copy link
Contributor

HLTV link
clg-red-vs-star-spangled-fraggers-m2-train-p1.dem

At tick number 118792 there is a PlayerHurt event with EqUnknown weapon. In the game the player was hurt with molotov projectile, which is stored as "molotov_projectile" in the raw event data. However, in the library we don't have mapping for this string (although we have it for "molotovprojectile"). I assumed that the similar problem may arise with other types of projectiles so I added appropriate mapping for them as well.

added *_projectile mapping
@ghost
Copy link

ghost commented Feb 24, 2020

Congratulations 🍻. DeepCode analyzed your code in 0.305 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@codeclimate
Copy link

codeclimate bot commented Feb 24, 2020

Code Climate has analyzed commit 38ea34f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@markus-wa markus-wa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markus-wa markus-wa merged commit 7200e0a into markus-wa:master Feb 24, 2020
@markus-wa
Copy link
Owner

thank you @BestAwperEver ! 🙂

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #187 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   91.87%   91.88%   +<.01%     
==========================================
  Files          29       29              
  Lines        2609     2612       +3     
==========================================
+ Hits         2397     2400       +3     
  Misses        159      159              
  Partials       53       53
Impacted Files Coverage Δ
common/equipment.go 98.73% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60d73c...38ea34f. Read the comment docs.

@BestAwperEver
Copy link
Contributor Author

At your service 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants