Feature: Update astro-icon
to v1 and svgo
#89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! My compliments to an excellent astro starter repo with great baseline accessibility.
When I first tried out this repo I ran into issues with
svgo
and it's dependencysharp
.While troubleshooting the build, I found that
astro-icon
had been updated to v1 with some breaking changes. After updating in my personal project I found the changes to be fairly straightforward and thought to replicate for you on the main repo.Most of the changes needed are documented in the
astro-icon
upgrade docs: https://www.astroicon.dev/guides/upgrade/v1/I also needed to make some minor changes to the css styles to match the current site design. These changes are needed as the
astro-icon
now delivers icons with thewidth
andheight
props, not previously present on the svg elements.package.json
changes:Cheers, and let me know if you have any questions.