Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak version detection in setup-integration-tests script #901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbrada
Copy link
Contributor

@jbrada jbrada commented Apr 6, 2023

I've made some changes to the setup-integration-test script that addresses an issue where it was not possible to use the script when a specific configuration of Xdebug was in place.

With this pull request, I've tweaked the version detection to evaluate only rows with the Magento string. The tweak should help to resolve the issue and make the script more reliable overall.

(this is an example output of bin/magento --version --no-ansi when xdebug is enabled on each request and disabled PHPStorm's Listening for Debug Connection)
image

Thank you @markshust for your hard work in maintaining this package!

@what-the-diff
Copy link

what-the-diff bot commented Apr 6, 2023

PR Summary

  • Updated script to support Magento 2.3
    The script has been improved to work with the latest version of Magento (2.3).
  • Switched to using grep for parsing version number
    The method to extract the version number has been changed from cut to grep, providing better reliability in parsing the version information from bin/magento --version output.

Copy link
Contributor

@piotrkwiecinski piotrkwiecinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants