Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mbit (4MB) 433Mhz v1.0 #35

Merged
merged 4 commits into from
May 3, 2023
Merged

Initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mbit (4MB) 433Mhz v1.0 #35

merged 4 commits into from
May 3, 2023

Conversation

mrmx
Copy link
Contributor

@mrmx mrmx commented Mar 13, 2023 •
edited
Loading

Added initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mbit (4MB) 433Mhz v1.0
Although I need to review it throughly because it does not work (oled black)

@mrmx mrmx changed the title Initial commit initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mt bit (4MB) 433Mhz v1.0 Mar 13, 2023
@mrmx mrmx changed the title initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mt bit (4MB) 433Mhz v1.0 Initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mt bit (4MB) 433Mhz v1.0 Mar 13, 2023
@mrmx mrmx changed the title Initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mt bit (4MB) 433Mhz v1.0 Initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mbit (4MB) 433Mhz v1.0 Mar 13, 2023
@mrmx
Copy link
Contributor Author

mrmx commented Mar 13, 2023

This is work in progress, needs revision and fix in its branch prior final merge approval with master.

@mrmx mrmx marked this pull request as draft March 13, 2023 11:30
@mrmx mrmx marked this pull request as ready for review March 13, 2023 11:30
@mrmx mrmx marked this pull request as draft March 13, 2023 11:30
@markqvist
Copy link
Owner

Thank you! Really appreciate this effort. It will be a little time before I can get to testing this, but I will get there :) Thanks for the patience ;)

@raytechnical
Copy link

Added initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mbit (4MB) 433Mhz v1.0 Although I need to review it throughly because it does not work (oled black)

Have a look at GPIO pin 21 as this may be the issue with the display not working. Active low, powers the oled display and the lora antenna boost?

@mrmx
Copy link
Contributor Author

mrmx commented Apr 1, 2023

Now the OLED is working (needed I2C Wire.begin call) and all pins are set up, although HW Failure is shown, but reading the code seems to be missing provisioning (add ROM.h product/model) but need guidance from @markqvist as how to proceed.. ;-)

@mrmx
Copy link
Contributor Author

mrmx commented Apr 1, 2023

Added initial support for TTGO LORA SX1278 ESP32 0.96 OLED 32Mbit (4MB) 433Mhz v1.0 Although I need to review it throughly because it does not work (oled black)

Have a look at GPIO pin 21 as this may be the issue with the display not working. Active low, powers the oled display and the lora antenna boost?

It was a matter of i2c initialization after reset

@markqvist
Copy link
Owner

Yeah, we need to assign proper model/board codes for it, and these need to be added to rnodeconf too. I am currently away from my computer, but will look at this in a few days or so, when I am back.

@markqvist markqvist mentioned this pull request May 2, 2023
Closed
markqvist
markqvist reviewed May 3, 2023
View reviewed changes
Makefile
arduino-cli compile --fqbn esp32:esp32:ttgo-lora32 -e --build-property "build.partitions=no_ota" --build-property "upload.maximum_size=2097152" --build-property "compiler.cpp.extra_flags=\"-DBOARD_MODEL=0x39\""

firmware-lora32_v10_extled:
arduino-cli compile --fqbn esp32:esp32:ttgo-lora32 -e --build-property "build.partitions=no_ota" --build-property "upload.maximum_size=2097152" --build-property "compiler.cpp.extra_flags=\"-DBOARD_MODEL=0x38\" \"-DEXTERNAL_LEDS=true\""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be BOARD_MODEL=0x39 here as well

Config.h
@@ -156,6 +157,20 @@
const int pin_led_rx = 14;
const int pin_led_tx = 32;
#define HAS_BLUETOOTH true
#define HAS_CONSOLE true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something has gone bonkers with all of the indentation here, but never mind, I will clean it up after merge.

README.md
@@ -81,7 +82,7 @@ The RNode Firmware supports all transceiver modules based on **Semtech SX1276**
Support for **SX1262**, **SX1268** and **SX1280** is being implemented. Please support the project with donations if you want this faster!

## Getting Started Fast
You can download and flash the firmware to all the supported boards using the [RNode Config Utility](https://github.com/markqvist/rnodeconfigutil). All firmware releases are now handled and installed directly through the `rnodeconf` utility, which is inclueded in the `rns` package. It can be installed via `pip`:
You can download and flash the firmware to all the supported boards using the [RNode Config Utility](https://github.com/markqvist/rnodeconfigutil). All firmware releases are now handled and installed directly through the `rnodeconf` utility, which is included in the `rns` package. It can be installed via `pip`:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fix :)

Makefile
@@ -181,6 +203,15 @@ release-lora32_v21:
zip --junk-paths ./Release/rnode_firmware_lora32v21.zip ./Release/esptool/esptool.py ./Release/console_image.bin build/rnode_firmware_lora32v21.boot_app0 build/rnode_firmware_lora32v21.bin build/rnode_firmware_lora32v21.bootloader build/rnode_firmware_lora32v21.partitions
rm -r build

release-lora32_v10_extled:
arduino-cli compile --fqbn esp32:esp32:ttgo-lora32 -e --build-property "build.partitions=no_ota" --build-property "upload.maximum_size=2097152" --build-property "compiler.cpp.extra_flags=\"-DBOARD_MODEL=0x38\" \"-DEXTERNAL_LEDS=true\""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check board model code

Makefile
cp build/esp32.esp32.ttgo-lora32/RNode_Firmware.ino.bin build/rnode_firmware_lora32v10.bin
cp build/esp32.esp32.ttgo-lora32/RNode_Firmware.ino.bootloader.bin build/rnode_firmware_lora32v10.bootloader
cp build/esp32.esp32.ttgo-lora32/RNode_Firmware.ino.partitions.bin build/rnode_firmware_lora32v10.partitions
zip --junk-paths ./Release/rnode_firmware_lora32v10.zip ./Release/esptool/esptool.py ./Release/console_image.bin build/rnode_firmware_lora32v10.boot_app0 build/rnode_firmware_lora32v10.bin build/rnode_firmware_lora32v10.bootloader build/rnode_firmware_lora32v10.partitions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the filename rnode_firmware_lora32v10.zip to rnodeconf, so please don't change it from here on. It will be the filename the flasher downloads while installing and flashing.

@markqvist markqvist marked this pull request as ready for review May 3, 2023 13:17
@markqvist
Copy link
Owner

Actually, I'll just merge this now, and fix the remaining few minor things, so we can get it tested out :)

@markqvist markqvist merged commit 023f6fa into markqvist:master May 3, 2023
@markqvist
Copy link
Owner

Ok, there should be support for flashing v1.0 boards from rnodeconf now, but you will need to use the one in the master github repo until v0.5.1 is released. Could you let me know if it works for you? I don't have any v1.0 boards to test this on ;)

@mrmx
Copy link
Contributor Author

mrmx commented May 21, 2023

The latest rnodeconf now sucessfully installs on the v1.0 TTGO LoRa!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markqvist markqvist markqvist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrmx @markqvist @raytechnical