Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atmega2560 support #12

Merged
merged 1 commit into from
Jan 8, 2022
Merged

atmega2560 support #12

merged 1 commit into from
Jan 8, 2022

Conversation

snh
Copy link
Contributor

@snh snh commented Dec 14, 2021

Tested on the Arduino Mega 2560 with a LoRa shield.

@markqvist
Copy link
Owner

Hi snh
Thanks for this. What is the status of this pull request? I saw you made some earlier comments on stability, was that resolved or did you still experience issues?

Since the atmega2560 only has 8KB of RAM, the send buffers definitely needs to be decreased.

Just trying to gauge whether this is ready for a merge into master, or you are still working on it / testing it?

@snh
Copy link
Contributor Author

snh commented Jan 8, 2022

So far it has been working OK in my basic testing, so it is probably ready for review. I do hope to test further over the next few weeks once I have a bit more time.

@markqvist
Copy link
Owner

Thanks. You mentioned something about issues with communicating with your 2560-based devices with rnodeconf, did you figure that out?

@markqvist markqvist merged commit 9ee61ee into markqvist:master Jan 8, 2022
@snh snh deleted the 2560 branch January 20, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants