This repository was archived by the owner on Sep 11, 2023. It is now read-only.
solve some syntax warnings#1530
Merged
Merged
Conversation
Member
|
Thanks alot @sroet :) this was bothering me for a while too but I never got around to fix it. |
Codecov Report
@@ Coverage Diff @@
## devel #1530 +/- ##
==========================================
- Coverage 92.06% 92.04% -0.02%
==========================================
Files 229 229
Lines 26833 26833
==========================================
- Hits 24704 24699 -5
- Misses 2129 2134 +5
Continue to review full report at Codecov.
|
Member
|
spurious test failure, merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
AUTHORSdoc/source/CHANGELOG(choose any open position to avoid merge conflicts with other PRs).Decide whether your change is a fix or a new feature.
Some
SyntaxWarning: "is" with a literal. Did you mean "=="?surfaced on downstream tests on the devel branch . This solves them