Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

solve some syntax warnings#1530

Merged
clonker merged 2 commits into
markovmodel:develfrom
sroet:solve_syntax_warnings
Jan 10, 2022
Merged

solve some syntax warnings#1530
clonker merged 2 commits into
markovmodel:develfrom
sroet:solve_syntax_warnings

Conversation

@sroet
Copy link
Copy Markdown
Contributor

@sroet sroet commented Jan 10, 2022

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • [NA] Make sure to include one or more tests for your change
  • [NA] Add yourself to AUTHORS
  • Add a new entry to the doc/source/CHANGELOG (choose any open position to avoid merge conflicts with other PRs).
    Decide whether your change is a fix or a new feature.

Some SyntaxWarning: "is" with a literal. Did you mean "=="? surfaced on downstream tests on the devel branch . This solves them

@clonker
Copy link
Copy Markdown
Member

clonker commented Jan 10, 2022

Thanks alot @sroet :) this was bothering me for a while too but I never got around to fix it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2022

Codecov Report

Merging #1530 (70bbc9b) into devel (b46e895) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1530      +/-   ##
==========================================
- Coverage   92.06%   92.04%   -0.02%     
==========================================
  Files         229      229              
  Lines       26833    26833              
==========================================
- Hits        24704    24699       -5     
- Misses       2129     2134       +5     
Impacted Files Coverage Δ
pyemma/coordinates/data/util/reader_utils.py 87.82% <100.00%> (ø)
...emma/_ext/variational/solvers/tests/test_direct.py 88.88% <0.00%> (-8.89%) ⬇️
pyemma/util/statistics.py 59.00% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46e895...70bbc9b. Read the comment docs.

@clonker
Copy link
Copy Markdown
Member

clonker commented Jan 10, 2022

spurious test failure, merging this.

@clonker clonker merged commit ea3439b into markovmodel:devel Jan 10, 2022
@sroet sroet deleted the solve_syntax_warnings branch January 10, 2022 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants