This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Update types.py#1503
Merged
Merged
Conversation
Contributor
Author
|
Appveyor build seem to fail on Conda stuff: |
Member
Member
|
PR is merged so you can rebase your changeset. |
import Iterable from collections.abc
Contributor
Author
rebased with a force push |
clonker
approved these changes
Jul 20, 2021
Member
clonker
left a comment
There was a problem hiding this comment.
Looks good to me! Will merge as soon as CI has run through.
Codecov Report
@@ Coverage Diff @@
## devel #1503 +/- ##
==========================================
- Coverage 92.03% 92.02% -0.02%
==========================================
Files 229 229
Lines 26804 26804
==========================================
- Hits 24670 24667 -3
- Misses 2134 2137 +3
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test for a downstream project is showing the following
DeprecationWarning:This fixes that Deprectation warning
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
AUTHORSdoc/source/CHANGELOG(choose any open position to avoid merge conflicts with other PRs).Decide whether your change is a fix or a new feature.