-
Notifications
You must be signed in to change notification settings - Fork 0
chore: update dev deps and configs #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8b584f4 to
bb3e2c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 1 1
Lines 378 378
Branches 79 79
=======================================
Hits 365 365
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Caution Review failedThe pull request is closed. WalkthroughCI workflows updated to use actions/checkout@v6 and actions/setup-node@v6, replace fixed Node versions with Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Comment |
1e90514 to
f7ee2c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
70-79: Re-addNPM_TOKENor properly configure OIDC for npm publishing.The
NPM_TOKENenvironment variable was removed, but the release workflow will fail whenchangeset publishattempts to publish to the npm registry. While theid-token: writepermission is set,setup-node@v6(lines 64-67) does not specify aregistry-url, so OIDC auto-configuration is not activated.Fix one of the following:
Re-add the secret:
env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} NPM_TOKEN: ${{ secrets.NPM_TOKEN }}Configure OIDC: Add
registry-urlto setup-node to enable npm OIDC provenance:- name: Setup node uses: actions/setup-node@v6 with: node-version: lts/* registry-url: 'https://registry.npmjs.org'
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.jsonand included by**
📒 Files selected for processing (3)
.github/workflows/ci.ymleslint.config.mjspackage.json
🔇 Additional comments (6)
.github/workflows/ci.yml (3)
57-60: LGTM!The permissions block is correctly scoped for the changesets action:
id-token: writeenables npm provenance via OIDCcontents: writefor pushing tags/commitspull-requests: writefor creating release PRs
34-36: LGTM!The LTS-based node version strategy (
lts/-2,lts/-1,lts/*) is a good practice. It automatically tests against the current and two previous LTS releases, ensuring forward compatibility without manual updates.
17-22: > Likely an incorrect or invalid review comment.package.json (1)
61-88: All specified package versions are published and available on npm. No availability concerns.The major version bumps you identified are real—@types/node, cross-env, globals, lint-staged, and mocha all have significant version increments in this update. These versions are confirmed to exist. If you haven't already, review the changelogs for these packages to ensure there are no breaking changes that affect your build or test setup, but the dependency versions themselves are valid.
eslint.config.mjs (2)
1-7: No changes required. ThedefineConfigimport from"eslint/config"is the correct import path for ESLint 9 flat config according to official ESLint documentation. The configuration follows the standard pattern.Likely an incorrect or invalid review comment.
17-19: No action needed.tseslint.configs.recommendedis correctly passed directly todefineConfig. This matches the official TypeScript ESLint documentation for ESLint's flat config format, where multiple config objects and arrays are passed as separate arguments todefineConfigrather than being spread.Likely an incorrect or invalid review comment.
d7238d7 to
4f79419
Compare
4f79419 to
a83e2e6
Compare
No description provided.