Skip to content

Conversation

@DylanPiercey
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (8559957) to head (a83e2e6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files           1        1           
  Lines         378      378           
  Branches       79       79           
=======================================
  Hits          365      365           
  Misses         12       12           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

CI workflows updated to use actions/checkout@v6 and actions/setup-node@v6, replace fixed Node versions with lts/*, lts/-1, lts/-2, rename several steps, adjust test job naming and setup sequence, add a permissions block for release jobs, and remove explicit NPM_TOKEN handling. ESLint config changed to import defineConfig from eslint/config, use defineConfig(...) as the default export, and pass tseslint.configs.recommended directly (removed the spread). package.json upgrades numerous devDependency versions.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, making it impossible to assess whether it relates to the changeset. Add a brief description explaining the purpose of the dependency and configuration updates, even if minimal.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: update dev deps and configs' accurately describes the main changes in the pull request—updating development dependencies and configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f79419 and a83e2e6.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json and included by **
📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • eslint.config.mjs
  • package.json

Comment @coderabbitai help to get the list of available commands and usage tips.

@DylanPiercey DylanPiercey force-pushed the deps-upgrade branch 2 times, most recently from 1e90514 to f7ee2c0 Compare January 6, 2026 16:45
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)

70-79: Re-add NPM_TOKEN or properly configure OIDC for npm publishing.

The NPM_TOKEN environment variable was removed, but the release workflow will fail when changeset publish attempts to publish to the npm registry. While the id-token: write permission is set, setup-node@v6 (lines 64-67) does not specify a registry-url, so OIDC auto-configuration is not activated.

Fix one of the following:

  1. Re-add the secret:

    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
  2. Configure OIDC: Add registry-url to setup-node to enable npm OIDC provenance:

    - name: Setup node
      uses: actions/setup-node@v6
      with:
        node-version: lts/*
        registry-url: 'https://registry.npmjs.org'
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8559957 and 1e90514.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json and included by **
📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • eslint.config.mjs
  • package.json
🔇 Additional comments (6)
.github/workflows/ci.yml (3)

57-60: LGTM!

The permissions block is correctly scoped for the changesets action:

  • id-token: write enables npm provenance via OIDC
  • contents: write for pushing tags/commits
  • pull-requests: write for creating release PRs

34-36: LGTM!

The LTS-based node version strategy (lts/-2, lts/-1, lts/*) is a good practice. It automatically tests against the current and two previous LTS releases, ensuring forward compatibility without manual updates.


17-22: > Likely an incorrect or invalid review comment.

package.json (1)

61-88: All specified package versions are published and available on npm. No availability concerns.

The major version bumps you identified are real—@types/node, cross-env, globals, lint-staged, and mocha all have significant version increments in this update. These versions are confirmed to exist. If you haven't already, review the changelogs for these packages to ensure there are no breaking changes that affect your build or test setup, but the dependency versions themselves are valid.

eslint.config.mjs (2)

1-7: No changes required. The defineConfig import from "eslint/config" is the correct import path for ESLint 9 flat config according to official ESLint documentation. The configuration follows the standard pattern.

Likely an incorrect or invalid review comment.


17-19: No action needed. tseslint.configs.recommended is correctly passed directly to defineConfig. This matches the official TypeScript ESLint documentation for ESLint's flat config format, where multiple config objects and arrays are passed as separate arguments to defineConfig rather than being spread.

Likely an incorrect or invalid review comment.

@DylanPiercey DylanPiercey force-pushed the deps-upgrade branch 3 times, most recently from d7238d7 to 4f79419 Compare January 6, 2026 16:56
@DylanPiercey DylanPiercey merged commit 824dbef into main Jan 6, 2026
11 checks passed
@DylanPiercey DylanPiercey deleted the deps-upgrade branch January 6, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants