Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #307 #308

Merged
merged 1 commit into from
Jun 14, 2016
Merged

fixes #307 #308

merged 1 commit into from
Jun 14, 2016

Conversation

mlrawlings
Copy link
Member

Only set prevClassName when the className has been pushed to finalClassNames, otherwise future className values will be appended to a class that doesn't get included in the final output. This effectively limits the number of classes to 2.

@coveralls
Copy link

coveralls commented Jun 14, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 83.42% when pulling 01f8a24 on mlrawlings:shorthand-classes into a60d007 on marko-js:master.

@patrick-steele-idem patrick-steele-idem merged commit 35c029f into marko-js:master Jun 14, 2016
@patrick-steele-idem
Copy link
Contributor

Thanks for the fix! New version published: marko@3.4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlrawlings @coveralls @patrick-steele-idem