Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<macro> must have a name #300

Merged
merged 2 commits into from
Jun 3, 2016
Merged

Conversation

mlrawlings
Copy link
Member

<macro> now expects its first attribute to be its name (regardless of whether it has arguments or not), if there are no attributes or the first attribute has a value (ex. test=123), then it throws an error.

✅ good:

<macro greeting>
    Hello!
</macro>

<macro greeting()>
    Hello!
</macro>

<macro greeting(name)>
    Hello ${name}!
</macro>

❌ bad:

<macro async=true>
    Uh-oh!
</macro>

<macro test=123 greeting(name)>
    Uh-oh ${name}!
</macro>

<macro>
    Uh-oh!
</macro>

@patrick-steele-idem patrick-steele-idem merged commit 78aeba9 into marko-js:master Jun 3, 2016
@patrick-steele-idem
Copy link
Contributor

Thanks! New version published with improvement and CHANGELOG.md updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants