Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade babel/it-fails, fix VComment #2306

Merged
merged 3 commits into from
Sep 27, 2024
Merged

fix: upgrade babel/it-fails, fix VComment #2306

merged 3 commits into from
Sep 27, 2024

Conversation

mlrawlings
Copy link
Member

@mlrawlings mlrawlings commented Sep 27, 2024

Description

  • updated VComment to not assume the host is the document
  • regenerated lockfile, primarily to update @babel/generate
  • updated it-fails to get a fix for an issue that caused the process to exit early
  • updated lots of snapshots that had whitespace changes due to @babel/generate changes

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

- updated VComment to not assume the host is the document
- regenerated lockfile, primarily to update @babel/generate
- updated it-fails to get a fix for an issue that caused the process to exit early
- updated lots of snapshots that had whitespace changes due to @babel/generate changes
Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: 738bfa3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.10%. Comparing base (ab914dc) to head (738bfa3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/marko/src/runtime/vdom/VComment.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
- Coverage   88.65%   88.10%   -0.56%     
==========================================
  Files         340      340              
  Lines       35345    35345              
  Branches     2060     2060              
==========================================
- Hits        31336    31141     -195     
- Misses       4009     4187     +178     
- Partials        0       17      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlrawlings mlrawlings merged commit 4d8eb53 into main Sep 27, 2024
7 of 9 checks passed
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant