Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all deps and configs #2076

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Upgrade all deps and configs #2076

merged 2 commits into from
Jan 9, 2024

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: a108d0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/translator-default Patch
@marko/babel-utils Patch
@marko/compiler Patch
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (efded7b) 85.02% compared to head (a108d0d) 85.01%.

Files Patch % Lines
...o/src/runtime/components/legacy/renderer-legacy.js 0.00% 14 Missing ⚠️
packages/babel-utils/src/tags.js 71.42% 4 Missing ⚠️
packages/marko/src/runtime/queueMicrotask.js 0.00% 4 Missing ⚠️
packages/compiler/src/babel-plugin/index.js 81.25% 3 Missing ⚠️
packages/compiler/src/babel-types/types/patch.js 25.00% 3 Missing ⚠️
packages/compiler/src/register.js 0.00% 3 Missing ⚠️
...ges/compiler/src/taglib/loader/loadTagFromProps.js 80.00% 3 Missing ⚠️
.../compiler/src/taglib/loader/loadTaglibFromProps.js 84.21% 3 Missing ⚠️
packages/marko/src/runtime/RenderResult.js 0.00% 3 Missing ⚠️
...runtime/components/legacy/defineRenderer-legacy.js 0.00% 3 Missing ⚠️
... and 35 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
- Coverage   85.02%   85.01%   -0.02%     
==========================================
  Files         225      226       +1     
  Lines       18857    18844      -13     
==========================================
- Hits        16034    16020      -14     
- Misses       2823     2824       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 69b3ff5 into main Jan 9, 2024
8 of 10 checks passed
@DylanPiercey DylanPiercey deleted the deps-upgrade-01-09-24 branch January 9, 2024 21:31
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
@nspector
Copy link

nspector commented Jan 9, 2024

@DylanPiercey The change from strip-json-comments to @luxass/strip-json-comments changed your min system requirements for node js as the engine required in @luxass/strip-json-comments is >=18. Can this change be done in a major version bump?

@DylanPiercey
Copy link
Contributor Author

@nspector I'll take a look and probably drop back to the older module here.
We run our CI on current node lts which passed for node 16, but I see the engines warnings there now.
https://github.com/marko-js/marko/actions/runs/7467209001/job/20320224037

@nspector
Copy link

nspector commented Jan 9, 2024

Thank you!

@DylanPiercey
Copy link
Contributor Author

DylanPiercey commented Jan 10, 2024

@nspector I kind of forgot that node 16 is actually not supported in LTS anymore. We only support LTS versions of node officially so I don't think it's worth worrying about this. If necessary you can either pin a lower version of Marko, or use --ignore-engines when installing since I'm pretty sure this module still works in node 16 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants