Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime loading in native esm #2056

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 023a69f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-default Patch
marko Patch
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (63fb73a) 84.98% compared to head (6808f19) 84.98%.

❗ Current head 6808f19 differs from pull request most recent head 023a69f. Consider uploading reports for the commit 023a69f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2056   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files         225      225           
  Lines       18810    18807    -3     
=======================================
- Hits        15985    15984    -1     
+ Misses       2825     2823    -2     
Files Coverage Δ
packages/marko/src/runtime/html/hot-reload.js 100.00% <100.00%> (ø)
packages/translator-default/src/index.js 86.50% <100.00%> (+0.02%) ⬆️
packages/marko/src/runtime/vdom/hot-reload.js 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 84f443d into main Nov 10, 2023
6 checks passed
@DylanPiercey DylanPiercey deleted the fix-runtime-load-in-native-esm branch November 10, 2023 20:13
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant