Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast): add type args and params #2051

Merged
merged 3 commits into from
Nov 10, 2023
Merged

feat(ast): add type args and params #2051

merged 3 commits into from
Nov 10, 2023

Conversation

LuLaValva
Copy link
Member

Description

Add type args and type params to the AST, primarily for use in tools like Prettier but also adds consistency with the rest of Babel parsing.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 6fd4703

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-default Patch
@marko/babel-utils Patch
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2400c56) 84.95% compared to head (6fd4703) 84.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
+ Coverage   84.95%   84.97%   +0.02%     
==========================================
  Files         225      225              
  Lines       18735    18807      +72     
==========================================
+ Hits        15916    15982      +66     
- Misses       2819     2825       +6     
Files Coverage Δ
packages/compiler/src/babel-plugin/parser.js 99.24% <100.00%> (+0.02%) ⬆️
...ckages/compiler/src/babel-types/generator/patch.js 98.46% <100.00%> (+0.08%) ⬆️
...ages/compiler/src/babel-types/types/definitions.js 100.00% <100.00%> (ø)
packages/babel-utils/src/parse.js 85.42% <77.77%> (-1.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit c113eda into main Nov 10, 2023
10 checks passed
@DylanPiercey DylanPiercey deleted the ast-type-params branch November 10, 2023 17:18
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants