Adds support for scoped packages to the marko-taglib.json scanner #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-steele-idem
added a commit
that referenced
this pull request
Dec 10, 2015
Adds support for scoped packages to the marko-taglib.json scanner
|
Hey @tropperstyle, thanks for the PR. I'll fix the jshint error that your code introduced and publish a new version. Thanks for the improvement. |
|
Hey @tropperstyle. I updated the code so that it still only did one pass through the directories: a55f3bb New version published: marko@2.8.0 Please let me know if you find any issues with the new code. Thanks! |
|
Working great! Thanks. Do you know off-top if there are any other places that scan node_modules where this check would be necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.