Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot reload fails if NODE_ENV is not 'development' or 'dev' #319

Closed
ianvonholt opened this issue Jun 27, 2016 · 0 comments
Closed

Hot reload fails if NODE_ENV is not 'development' or 'dev' #319

ianvonholt opened this issue Jun 27, 2016 · 0 comments

Comments

@ianvonholt
Copy link
Contributor

I tracked down a bug with hot-reloaded templates not re-compiling if NODE_ENV is set to values other than "development" or "dev".

The error stems from:
https://github.com/marko-js/marko/blob/master/runtime/loader.js#L102-L108
and
https://github.com/marko-js/marko/blob/master/compiler/config.js#L24

The assumeUpToDate variable should take into consideration that the files are being hot-reloaded before taking the node environment into consideration.
ianvonholt added a commit to ianvonholt/marko that referenced this issue Jun 27, 2016
@ianvonholt
Adding detection for process.env.MARKO_HOT_RELOAD with assumeUpToDate…
c76ffa2 
… configuration variable. If files are hot reloaded, we should never assume that they are up to date.

Fixes issue marko-js#319
@ianvonholt ianvonholt mentioned this issue Jun 27, 2016
Merged
@ianvonholt ianvonholt changed the title Hot Reload Fails if NODE_ENV is not 'development' or 'dev' Hot reload fails if NODE_ENV is not 'development' or 'dev' Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianvonholt