Clone the events object when running render tests

marko-js · Oct 11, 2017 · 5f686b8 · 5f686b8
1 parent 83f711d
commit 5f686b8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -98,6 +98,7 @@
     "browser-refresh-taglib": "^1.1.0",
     "chai": "^3.3.0",
     "child-process-promise": "^2.2.1",
+    "clone": "^2.1.1",
     "codecov": "^2.3.0",
     "coveralls": "^2.13.1",
     "express": "^4.16.1",

diff --git a/test/util/runRenderTest.js b/test/util/runRenderTest.js
@@ -10,7 +10,7 @@ const domToHTML = require('./domToHTML');
 const domToString = require('./domToString');
 
 const expect = require('chai').expect;
-
+const clone = require('clone');
 
 
 function createAsyncVerifier(main, helpers, out) {
@@ -29,7 +29,7 @@ function createAsyncVerifier(main, helpers, out) {
 
             events.push({
                 event: event,
-                arg: arg
+                arg: clone(arg)
             });
         });
     };
@@ -149,8 +149,7 @@ module.exports = function runRenderTest(dir, helpers, done, options) {
                 asyncEventsVerifier = createAsyncVerifier(main, helpers, out);
             }
 
-            out.on('error', done);
-            out.on('finish', function(result) {
+            function verifyOutput(result) {
                 var renderOutput = result.getOutput();
 
                 if (isVDOM) {
@@ -235,7 +234,19 @@ module.exports = function runRenderTest(dir, helpers, done, options) {
 
                     done();
                 }
-            });
+            }
+
+            out.then(
+                function onFulfilled(result) {
+                    process.nextTick(function() {
+                        verifyOutput(result);
+                    });
+                },
+                function onRejected(err) {
+                    process.nextTick(function() {
+                        done(err);
+                    });
+                });
 
             template.render(templateData, out).end();
         }