Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Oauth2 v2.0 #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NicolasMarlier
Copy link

@marknadig
Copy link
Owner

Thanks for contributing. However, I no longer have time to maintain this gem. Your best bet is to fork it and consider publishing to RubyGems so others can benefit.

whithajess added a commit to RIPAGlobal/omniauth-entra-id that referenced this pull request Sep 14, 2020
* Support for Oauth2 v2.0 marknadig/omniauth-azure-oauth2#29
* Make it work with this new gem
@whithajess
Copy link

whithajess commented Feb 26, 2021

For anyone thats looking for this we have published a v2 compatible gem based on this no longer maintained project here:

Actively maintained and lots of usage now.

@krtschmr
Copy link

krtschmr commented Sep 7, 2021

Thanks for contributing. However, I no longer have time to maintain this gem. Your best bet is to fork it and consider publishing to RubyGems so others can benefit.

while i appreciate your statement, i believe this is wrong in the sense of open source. transfer ownership to 2-3 other people and development could go forward. what's stopping you to actually do this?

@marknadig
Copy link
Owner

@krtschmr I agree best would be to transfer ownership. However, I think there's the issue of trust. It would be irresponsible for me to just hand over maintaining to the first person that raised their hand. I would only feel comfortable transferring to someone that's been involved already with pull requests, etc.
Buy providing a 'clean break' folks can vet any new forks by new maintainers. That was my intent.

@krtschmr
Copy link

krtschmr commented Sep 7, 2021

i understand and respect that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants