-
Notifications
You must be signed in to change notification settings - Fork 16
PDP-473: Create pr-workflow.yaml #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| name: 🏷️ JIRA ID Validator | ||||||
|
|
||||||
| on: | ||||||
| # Using pull_request_target instead of pull_request to handle PRs from forks | ||||||
| pull_request_target: | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| types: [opened, edited, reopened, synchronize] | ||||||
| # No branch filtering - will run on all PRs | ||||||
|
|
||||||
| jobs: | ||||||
| jira-pr-check: | ||||||
| name: 🏷️ Validate JIRA ticket ID | ||||||
| # Use the reusable workflow from the central repository | ||||||
| uses: marklogic/pr-workflows/.github/workflows/jira-id-check.yml@main | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pin the reusable workflow reference to a specific tag or commit SHA instead of
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
| with: | ||||||
| # Pass the PR title from the event context | ||||||
| pr-title: ${{ github.event.pull_request.title }} | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a
concurrencystanza at the workflow level to cancel in-progress runs for the same PR (e.g.,concurrency: { group: 'pr-${{ github.event.pull_request.number }}', cancel-in-progress: true }), preventing overlapping validations.Copilot uses AI. Check for mistakes.