Skip to content

Fixing bug where a 'naked' properties fragment cannot be written #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2024

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented May 1, 2024

The check on content being null was overly restrictive, as v1/documents allows for null content. This may cause some other DMSDK test to fail, in which case that test will be modified as null content is allowable here.

@rjrudin rjrudin requested review from anu3990 and BillFarber as code owners May 1, 2024 19:44
BillFarber
BillFarber previously approved these changes May 1, 2024
Copy link
Contributor

@BillFarber BillFarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending test fix

The check on content being null was overly restrictive, as v1/documents allows for null content. This may cause some other DMSDK test to fail, in which case that test will be modified as null content is allowable here.
@rjrudin rjrudin force-pushed the feature/null-content-writeBatcher branch from c0c7837 to 796f0d0 Compare May 1, 2024 21:08
@rjrudin rjrudin requested a review from BillFarber May 6, 2024 15:09
@rjrudin rjrudin merged commit 67f1c6e into develop May 14, 2024
1 check passed
@rjrudin rjrudin deleted the feature/null-content-writeBatcher branch May 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants