DEVEXP-469 Optimistic locking failures now throw concrete exceptions #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillFarber
previously approved these changes
Aug 22, 2023
Users no longer need to parse out exception messages. And now `TestOptimisticLocking` doesn't need to either, which allowed me to delete a bunch of code from it in favor of asserting on specific exception classes. This is a non-breaking change as the new exceptions are subclasses of `FailedRequestException` and contain the same error message.
rjrudin
force-pushed
the
feature/469-optimistic
branch
from
b9b4ad0 to
9ce673a
Compare
BillFarber
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users no longer need to parse out exception messages. And now
TestOptimisticLockingdoesn't need to either, which allowed me to delete a bunch of code from it in favor of asserting on specific exception classes.This is a non-breaking change as the new exceptions are subclasses of
FailedRequestExceptionand contain the same error message.