DEVEXP-508 Certificate auth no longer requires a file path #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DatabaseClientBuilder` now supports the constructor that accepts an `SSLContext` and `X509TrustManager` without requiring a certificate file and password.
rjrudin
commented
Jul 18, 2023
| @@ -158,6 +158,12 @@ public DatabaseClientBuilder withCertificateAuth(String file, String password) { | |||
| .withCertificatePassword(password); | |||
| } | |||
|
|
|||
| public DatabaseClientBuilder withCertificateAuth(SSLContext sslContext, X509TrustManager trustManager) { | |||
There was a problem hiding this comment.
This was not needed for the fix, it's just some syntactic sugar for the use case of doing certificate auth with a user-provided SSLContext instead of a certificate file path.
| } | ||
| return new DatabaseClientFactory.CertificateAuthContext(sslInputs.getSslContext(), sslInputs.getTrustManager()); |
There was a problem hiding this comment.
This is the actual fix - if the user doesn't provide a certificate file, then use the SSLContext and X509TrustManager that they provided.
BillFarber
approved these changes
Jul 18, 2023
anu3990
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatabaseClientBuildernow supports the constructor that accepts anSSLContextandX509TrustManagerwithout requiring a certificate file and password.