Added test for a custom X509TrustManager #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
commented
Jun 13, 2023
| CertificateTemplateManager mgr = new CertificateTemplateManager(Common.newManageClient()); | ||
|
|
||
| Fragment response = mgr.getCertificatesForTemplate(TEMPLATE_NAME); | ||
| String cert = response.getElementValue("/msec:certificate-list/msec:certificate/msec:pem"); |
There was a problem hiding this comment.
@BillFarber Could reproduce this in mlxprs if needed, though I don't know how to make a certificate / trust manager in Node or what the equivalent is. But this is the key part - after generating a temporary certificate, you can download it and get the pem via the above code.
There was a problem hiding this comment.
I've been thinking that we need to add a test or two to exercise certs, but I haven't written any stories for it.
BillFarber
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured out the plumbing for doing this with the Manage API, figured I should document it via a test here.