Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Pipes user, it's not clear to me how to define Subgraph inputs and outputs so that they are visible in the main graph #158

Closed
josvanroosmalen opened this issue Apr 1, 2020 · 6 comments

Comments

@josvanroosmalen
Copy link
Collaborator

Before I start working on compiler support for subgraphs, I tried to create a subgraph, but it is not working on master.

Reproduction:

  • Start Pipes

image

  • Add Sugraph

image

  • Open Subgraph
  • Add Graph -> Input
  • Add Graph -> Output
  • Add String -> Normalize Space (or link input to output directly)
  • Link them together

image

  • Close the subgraph

  • ERROR The input/output is not visible

image

@danielholgate
Copy link
Contributor

@epoilvet any idea about this? I've not changed the way subgraphs work..
@josvanroosmalen I presume this worked in Beta 4?

@epoilvet
Copy link
Contributor

epoilvet commented Apr 1, 2020

Input/ouput names are mandatory in Litegraph framework to be able to see the plug.
99% sure this is the reason why you don't see it.
In the screenshots, the fields still have their name empty (it displays "name" in the input field)

@josvanroosmalen
Copy link
Collaborator Author

Yes it is working if you set name. However this is a big usability "concern" because "new" user no doubt are also going to do this. Can't we by default not give a default name ("input1" and "output1"). Because a subgraph can have multiple input/outputs this need to be dynamic. So if you auto generate a name "input1", you need to check that already exist. If so, try "input2" and so on.

@josvanroosmalen
Copy link
Collaborator Author

Can this be fixed together with #134 because #134 was one of the most annoying feedback we got from the POC.

@sashamitrovich sashamitrovich added this to the 1.0.1 milestone Apr 2, 2020
@sashamitrovich
Copy link
Contributor

It would be great to fix this for 1.0.1

@sashamitrovich sashamitrovich added enhancement New feature or request user-interface and removed bug Something isn't working labels Apr 2, 2020
@sashamitrovich sashamitrovich changed the title Subgraph not working -> input/output are not visible As a Pipes user, it's not clear to me how to define Subgraph inputs and outputs so that they are visible in the main graph Apr 2, 2020
epoilvet added a commit that referenced this issue Apr 2, 2020
#158 As a Pipes user, it's not clear to me how to define Subgraph inputs and outputs so that they are visible in the main graph
@josvanroosmalen
Copy link
Collaborator Author

working in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants