Envelope attachment not working on master

[josvanroosmalen]

In this example, we want to feed the staging URI to the attachment (eg for lineage purpose).

This is not working. Well basically attachment is not work at all. Even if I feed the "input" node input to attachment it is also not working.

See e.g. the attached ZIP file. Run this on any collection on any database, and attachment will be empty.

AttachmentErrorFinal-00.01.json.zip

[josvanroosmalen]

Impacting POC: "W" ( @taatuut )

[taatuut]

We hit this issue in the WSRL PoC. Blocks the possibility to get the right data in the Final document attachment. The example we have, is that we want to store staging node or URI in the attachment so we can easily track back where data (or problems) come from. Is there a workaround to get data in the envelope attachment currently?

[epoilvet]

I think its a side effect of datahub.flow.flowUtils.makeEnvelope which requires a instance (not null) to manage attachements. Checking

[epoilvet]

Fixed in master

[josvanroosmalen]

Thanks Eric.

[sashamitrovich]

Need to add test.

[josvanroosmalen]

Assigned to Sasha for the unit test!?

[sashamitrovich]

Yes On 2. Apr 2020, at 11:44, Jos van Roosmalen <notifications@github.com> wrote:  Assigned to Sasha for the unit test!? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub<#148 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADXC6NZQMQENK6CVCPA2G3LRKRM7DANCNFSM4LW5OWXQ>.