Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Lookup is still not dynamic #122

Closed
josvanroosmalen opened this issue Mar 26, 2020 · 3 comments
Closed

Feature/Lookup is still not dynamic #122

josvanroosmalen opened this issue Mar 26, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@josvanroosmalen
Copy link
Collaborator

@danielholgate did great work, but it is still not dynamic.

The number of sliced fields is still hardcoded (in execution) to the number of fields added hardcoded in core.sjs.

For example we have in the latest commit 10 hardcoded valuePaths, however this limits the extraction to 10 in execution. If you put in the editor nbOfValuesPath on 15 then the last 5 do not work in preview.

This should be removed because we build this dynamic. During execution this seems not to be build dynamic, so then we are stuck to 10. If you remove this entirely from core.sjs the block will not work anymore because during execution this is not build dynamically.

    this.value0Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value1Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value2Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value3Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value4Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value5Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value6Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value7Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value8Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.value9Path = this.addWidget("text","nbOutputValues", "", function(v){},  { } );
    this.addOutput("val0");
    this.addOutput("val1");
    this.addOutput("val2");
    this.addOutput("val3");
    this.addOutput("val4");
    this.addOutput("val5");
    this.addOutput("val6");
    this.addOutput("val7");
    this.addOutput("val8");
    this.addOutput("val9");
@josvanroosmalen josvanroosmalen added the bug Something isn't working label Mar 26, 2020
@danielholgate
Copy link
Contributor

Can you confirm where the code you showed above is? Is it currently in the project

@josvanroosmalen
Copy link
Collaborator Author

This code is in core.sjs. If you reduce this to 1 (so value0pathand val0 only, you will see that it is not executing for paths > 1. So the execution parts is limited to the number of hardcoded ones (in this case 10).

danielholgate added a commit that referenced this issue Mar 30, 2020
Not dynamic, but 20 outputs now created for these two blocks which should cover any realistic situation
@danielholgate
Copy link
Contributor

Not possible to make this dynamic, but simply providing 20 outputs solves the problem for every realistic situation

@danielholgate danielholgate added this to the 1.0.1 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants