Enhance error handling for ContentSource to instantiate a new one #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us some minor edits for code formatting and whatnot.
…rent than the current ContentSource - Add option CONTENT-SOURCE-RENEW to allow users to configure whether to create a fresh ContentSource onError
Member
Author
|
@bbandlamudi as discussed, changed to only swap ContentSource if IP has changed, and to have an option to enable/disable the behavior (but have it enabled by default). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, XCC resolves the IP of a host when instantiated and it remains static. This can be problematic for proxies that have a dynamic set of nodes backing it, such as Amazon ALB or ELB. If a proxy node is removed from the pool, then a long-running job can encounter errors when that IP goes dark.
Instantiating a new ContentSource will resolve the IP again, and should help keeping the jobs from stalling our or failing.