Collect diagnostic information if failed to start a process. (kokorin…

…#238) Fix kokorin#224.
marklassau · Oct 19, 2021 · 6b026e6 · 6b026e6
1 parent 752a018
commit 6b026e6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/main/java/com/github/kokorin/jaffree/process/ProcessHandler.java b/src/main/java/com/github/kokorin/jaffree/process/ProcessHandler.java
@@ -24,6 +24,7 @@
 import java.io.Closeable;
 import java.io.IOException;
 import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -145,10 +146,10 @@ public synchronized T execute() {
 
                 return interactWithProcess(process);
             } catch (IOException e) {
+                collectDebugInformation();
                 throw new JaffreeException("Failed to start process.", e);
             } finally {
                 if (process != null) {
-                    // TODO on Windows process sometimes doesn't stop and keeps running
                     process.destroy();
                     // Process must be destroyed before closing streams, can't use
                     // try-with-resources, as resources are closing when leaving try block,
@@ -320,4 +321,17 @@ private static void waitForExecutorToStop(final Executor executor, final long ti
             Thread.sleep(100);
         } while (executor.isRunning());
     }
+
+    private static void collectDebugInformation() {
+        try {
+            LOGGER.warn("Collecting debug information");
+            LOGGER.warn("User: {}", System.getProperty("user.name"));
+            LOGGER.warn("OS: {}", System.getProperty("os.name"));
+            LOGGER.warn("User Dir: {}", System.getProperty("user.dir"));
+            LOGGER.warn("Work Dir: {}", Paths.get(".").toAbsolutePath());
+            LOGGER.warn("PATH: {}", System.getenv("PATH"));
+        } catch (Exception e) {
+            LOGGER.warn("Failure while collecting debug information.", e);
+        }
+    }
 }
diff --git a/src/test/java/com/github/kokorin/jaffree/ffmpeg/FFmpegTest.java b/src/test/java/com/github/kokorin/jaffree/ffmpeg/FFmpegTest.java
@@ -8,6 +8,7 @@
 import com.github.kokorin.jaffree.ffprobe.FFprobe;
 import com.github.kokorin.jaffree.ffprobe.FFprobeResult;
 import com.github.kokorin.jaffree.ffprobe.Stream;
+import com.github.kokorin.jaffree.process.ProcessHandler;
 import com.github.kokorin.jaffree.process.ProcessHelper;
 import org.hamcrest.core.AllOf;
 import org.hamcrest.core.StringContains;
@@ -906,4 +907,13 @@ public void testAsyncToCompletableFuture() throws Exception {
 
         assertEquals(2, probeResult.getStreams().size());
     }
+
+    @Test
+    @Ignore("Should be ran manually")
+    public void testNoFFmpegExecutableFound() {
+        FFmpeg.atPath(Paths.get("."))
+                .addInput(UrlInput.fromPath(Artifacts.VIDEO_MP4))
+                .addOutput(new NullOutput())
+                .execute();
+    }
 }