Skip to content

Added AllowedFileTypes to filter the dialog. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2020
Merged

Added AllowedFileTypes to filter the dialog. #13

merged 2 commits into from
Nov 1, 2020

Conversation

@rishi-shah
Copy link
Contributor

Fix for Filter Dialog

@marijnz0r
Copy link
Contributor

Could we accept .wav, .flac and .ogg as well?

@rishi-shah
Copy link
Contributor Author

rishi-shah commented Nov 1, 2020 •
edited
Loading

Could we accept .wav, .flac and .ogg as well?

Hi,
I tried to add all three extension, but during testing, .ogg files wasn't being played and the app crashed. I have committed support .wav and .flac files.

markjamesm
markjamesm approved these changes Nov 1, 2020
View reviewed changes
Copy link
Owner

@markjamesm markjamesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works on my end with this update in place. Thanks for submitting this patch!

@markjamesm markjamesm merged commit c7b79aa into markjamesm:main Nov 1, 2020
@rishi-shah rishi-shah deleted the patch-1 branch November 1, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markjamesm markjamesm markjamesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishi-shah @marijnz0r @markjamesm