feat: Added support for plain dbal #413

jorgerobles · 2025-11-12T19:21:33Z

Features a plain DBAL adapter

Optimized queries beyond object manager
Custom table and columns via configuration.

Copilot

Pull Request Overview

This PR introduces plain DBAL adapter support for JWT refresh tokens, enabling direct database access without requiring an ORM or ODM layer. This provides performance benefits through optimized queries and allows custom table and column configurations.

Key Changes:

Added RefreshTokenManager for DBAL with direct SQL queries and custom column mapping
Implemented automatic table creation via TableSchemaManager and EnsureTableExistsListener
Extended configuration to support DBAL connection settings with mutual exclusivity validation against object manager

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tests/Functional/Doctrine/DBAL/RefreshTokenManagerTest.php	New test suite for DBAL refresh token manager covering save, retrieve, delete, and revoke operations
tests/Functional/DependencyInjection/GesdinetJWTRefreshTokenExtensionTest.php	Added tests for DBAL connection validation and configuration
tests/Functional/DependencyInjection/ConfigurationTest.php	Added tests for DBAL configuration options including table name, columns, and mutual exclusivity
src/GesdinetJWTRefreshTokenBundle.php	Registered ValidateDBALConnectionCompilerPass for connection validation
src/EventListener/EnsureTableExistsListener.php	New listener that automatically creates refresh token table on first request using ConfigCache
src/Doctrine/DBAL/TableSchemaManager.php	New service for managing database schema including table creation and configuration
src/Doctrine/DBAL/RefreshTokenManager.php	New DBAL-based implementation of RefreshTokenManagerInterface with custom column mapping support
src/DependencyInjection/GesdinetJWTRefreshTokenExtension.php	Updated to support DBAL configuration and conditionally load DBAL or ORM services
src/DependencyInjection/Configuration.php	Added DBAL configuration nodes including connection, table name, auto-create, and column mapping
src/DependencyInjection/Compiler/ValidateDBALConnectionCompilerPass.php	New compiler pass that validates DBAL connection exists and provides helpful error messages
config/services.php	Removed inline refresh token manager definition to support conditional loading
config/om_services.php	New file defining object manager-based refresh token manager service
config/dbal_services.php	New file defining DBAL-based services including manager, schema manager, and table listener
composer.json	Updated rector/rector version constraint and added phpstan/phpstan dependency
.php-cs-fixer.dist.php	Added PHP CS Fixer configuration file for code style enforcement
.php-cs-fixer.cache	Generated cache file from PHP CS Fixer execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Doctrine/DBAL/RefreshTokenManager.php

tests/Functional/DependencyInjection/GesdinetJWTRefreshTokenExtensionTest.php

src/Doctrine/DBAL/RefreshTokenManager.php

src/EventListener/EnsureTableExistsListener.php

src/DependencyInjection/Configuration.php

src/Doctrine/DBAL/RefreshTokenManager.php

src/DependencyInjection/Compiler/ValidateDBALConnectionCompilerPass.php

shakaran · 2025-12-02T16:44:21Z

@jorgerobles I will need that you update the PR with the changes properly and pass the unit tests to consider to be merged for release 2.0 or upper

jorgerobles · 2025-12-02T21:45:28Z

@jorgerobles I will need that you update the PR with the changes properly and pass the unit tests to consider to be merged for release 2.0 or upper

all the issues are solved, but cannot pass through some pipelines.
ran locally with nektos/act but are stuck on some mongo errors, not related with current PR.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 18 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Doctrine/DBAL/RefreshTokenManager.php

src/EventListener/EnsureTableExistsListener.php

src/Doctrine/DBAL/RefreshTokenManager.php

src/Doctrine/DBAL/TableSchemaManager.php

src/Doctrine/DBAL/RefreshTokenManager.php

src/EventListener/EnsureTableExistsListener.php

src/Doctrine/DBAL/RefreshTokenManager.php

.php-cs-fixer.dist.php

src/DependencyInjection/Configuration.php

src/Doctrine/DBAL/RefreshTokenManager.php

shakaran · 2025-12-03T19:04:23Z

@jorgerobles please fix all issues mentioned by copilot and dont commit .php-cs-fixer.cache

jorgerobles · 2025-12-03T20:19:38Z

@jorgerobles please fix all issues mentioned by copilot and dont commit .php-cs-fixer.cache

Done!

…/GesdinetJWTRefreshTokenExtensionTest.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ty warnings

Copilot

Pull request overview

Copilot reviewed 16 out of 17 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Model/AbstractRefreshToken.php

tests/Functional/DependencyInjection/GesdinetJWTRefreshTokenExtensionTest.php

src/DependencyInjection/Configuration.php

src/Doctrine/DBAL/TableSchemaManager.php

src/Doctrine/DBAL/RefreshTokenManager.php

tests/Functional/EventListener/EnsureTableExistsListenerTest.php

tests/Functional/Doctrine/DBAL/RefreshTokenManagerTest.php

tests/Functional/EventListener/EnsureTableExistsListenerTest.php

config/services.php

function.alreadyNarrowedType which seems unusual. The method.notFound suppression is reasonable for backwards compatibility with Symfony < 5.3, but function.alreadyNarrowedType suggests there might be dead code Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

The batch size parameter has a minimum value of 0 in the configuration (line 122), but the PHPDoc annotations throughout the codebase specify positive-int for batch sizes (e.g., RefreshTokenManager.php:30, :192, :295). This is inconsistent. A batch size of 0 doesn't make sense and could cause infinite loops. Consider changing the minimum to 1. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jorgerobles · 2026-01-03T11:53:28Z

@shakaran Is necessary to support largely deprecated and unmaintained packages for the new 2.0 version?

Doctrine introduced several BC, in Connection and QueryBuilder

Doctrine < 3.6
$connection->createSchemaManager())

Doctrine 2.x
$querybuilder->execute()->fetch(PDO::FETCH_ASSOC)

jorgerobles force-pushed the dbal branch 2 times, most recently from 295feb8 to b698fce Compare November 12, 2025 19:34

shakaran added this to the 2.0 milestone Nov 13, 2025

shakaran added enhancement documentation labels Nov 13, 2025

shakaran requested a review from Copilot November 13, 2025 12:39

Copilot started reviewing on behalf of shakaran November 13, 2025 12:39 View session

Copilot finished reviewing on behalf of shakaran November 13, 2025 12:42

Copilot AI reviewed Nov 13, 2025

View reviewed changes

jorgerobles force-pushed the dbal branch from 6500bbc to c89a8c4 Compare December 2, 2025 19:25

shakaran requested a review from Copilot December 3, 2025 18:47

Copilot started reviewing on behalf of shakaran December 3, 2025 18:48 View session

Copilot finished reviewing on behalf of shakaran December 3, 2025 18:53

Copilot AI reviewed Dec 3, 2025

View reviewed changes

jorgerobles force-pushed the dbal branch 2 times, most recently from 6b14cef to 4c1a4bc Compare December 3, 2025 19:21

jorgerobles and others added 10 commits December 3, 2025 21:20

feat: added dbal

4c4c4b3

chore: php-cs-fixer

c0e74da

fix: phpunit tests

ece34df

fix: service definition alias

c1e85a2

refactor: drop narrow use of returning

ebdc168

fix: hydration bug

0dad29f

refactor: drop unit testing in favor to functional test.

4466b6c

chore: cs

c79ccc1

chore: rector

65ed39b

fix: combine expectExceptions at tests/Functional/DependencyInjection…

7ff412e

…/GesdinetJWTRefreshTokenExtensionTest.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jorgerobles added 7 commits December 3, 2025 21:20

fix: add default value for dbal_columns configuration

c460c59

fix: add SQL identifier quoting and consolidate DBAL code

150690c

fix: improve exception handling in EnsureTableExistsListener

e7bb589

chore: add PHPStan type annotations and suppress backward compatibili…

7b699db

…ty warnings

feat: add logging to EnsureTableExistsListener for better debugging

3400710

test: add comprehensive test coverage for RefreshTokenManager

ac8a50c

fix: correct batch deletion offset logic and add empty guard

445cde5

jorgerobles force-pushed the dbal branch from 67421cb to 445cde5 Compare December 3, 2025 20:21

shakaran force-pushed the master branch from a5300b7 to 9d3d43c Compare December 3, 2025 21:01

shakaran requested a review from Copilot December 3, 2025 21:36

Copilot started reviewing on behalf of shakaran December 3, 2025 21:36 View session

Copilot finished reviewing on behalf of shakaran December 3, 2025 21:39

Copilot AI reviewed Dec 3, 2025

View reviewed changes

shakaran and others added 16 commits December 3, 2025 22:44

fix: use s+ for spaces

6689812

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: use FDQN class

cad3495

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: dont use silence operator

09bf0d2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: put alphabetical order in namespaces

9d1d41d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Doctrine/DBAL/TableSchemaManager.php

a0ac36c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: add SQL identifier validation for DBAL table and column names

2e23605

refactor: extract TestLogger to reusable test fixture

47fd006

fix: replace invalid rollback test with exception handling test

a5bc3f8

chore: style-ci

e2a166e

chore: fix union type

26e5e83

chore: psalm fix

84bb874

chore: styleci

0bc750f

Merge branch 'master' into dbal

8ca010c

fix: retrofit TestLogger interface implementation.

b17fe9a

feat: Added support for plain dbal #413

Are you sure you want to change the base?

feat: Added support for plain dbal #413

Uh oh!

Conversation

jorgerobles commented Nov 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shakaran commented Dec 2, 2025

Uh oh!

jorgerobles commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shakaran commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jorgerobles commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jorgerobles commented Jan 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shakaran commented Dec 3, 2025 •

edited

Loading