Skip to content

Commit

Permalink
Adjust indentation of TODOs in third_party/2/gflags.pyi. (python#2964)
Browse files Browse the repository at this point in the history
Having TODOs at a different level of indentation than
the surrounding lines trips up pytype.
  • Loading branch information
rchen152 authored May 7, 2019
1 parent e4a8113 commit a6d92ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion tests/pytype_blacklist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ stdlib/3/typing.pyi

# third_party stubs with constructs that pytype doesn't yet support:
third_party/2/fb303/FacebookService.pyi
third_party/2/gflags.pyi
third_party/2/scribe/scribe.pyi
third_party/2/tornado/gen.pyi
third_party/2/tornado/httpserver.pyi
Expand Down
6 changes: 3 additions & 3 deletions third_party/2/gflags.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class FlagValues:
def UseGnuGetOpt(self, use_gnu_getopt: bool = ...) -> None: ...
def is_gnu_getopt(self) -> bool: ...
IsGnuGetOpt = is_gnu_getopt
# TODO dict type
# TODO dict type
def FlagDict(self) -> dict: ...
def flags_by_module_dict(self) -> Dict[str, List[Flag]]: ...
FlagsByModuleDict = flags_by_module_dict
Expand Down Expand Up @@ -83,7 +83,7 @@ class FlagValues:
AppendFlagsIntoFile = append_flags_into_file
def write_help_in_xml_format(self, outfile: IO[str] = ...) -> None: ...
WriteHelpInXMLFormat = write_help_in_xml_format
# TODO validator: gflags_validators.Validator
# TODO validator: gflags_validators.Validator
def AddValidator(self, validator: Any) -> None: ...

FLAGS: FlagValues
Expand Down Expand Up @@ -113,7 +113,7 @@ class Flag:

class ArgumentParser(object):
syntactic_help: str
# TODO what is this
# TODO what is this
def parse(self, argument: Any) -> Any: ...
Parser = parse
def flag_type(self) -> str: ...
Expand Down

0 comments on commit a6d92ec

Please sign in to comment.