chore: update workflow to use trusted publishing#3880
chore: update workflow to use trusted publishing#3880UziTech merged 1 commit intomarkedjs:masterfrom
Conversation
|
@UziTech is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello @UziTech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant update to the project's release workflow, transitioning to a more secure and recommended 'trusted publishing' model. This change necessitates updates to various core dependencies, particularly Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the package-lock.json file, reflecting various dependency updates across several @actions, @npmcli, and @sigstore packages. This is a positive step towards updating the release workflow to use trusted publishing. Notably, there are major version bumps for common-ancestor-path and lru-cache within the npm dependency tree, which also involve changes in their licenses. It is important to ensure these major version updates do not introduce breaking changes and that the new licenses are compatible with the project's licensing policy.
| "bin-links": "^6.0.0", | ||
| "cacache": "^20.0.1", | ||
| "common-ancestor-path": "^1.0.1", | ||
| "common-ancestor-path": "^2.0.0", |
There was a problem hiding this comment.
The common-ancestor-path dependency has been updated from version 1.0.1 to 2.0.0, which is a major version bump. Additionally, its license has changed from ISC to BlueOak-1.0.0. Please confirm that this major version update does not introduce any breaking changes and that the new license is compatible with our project's licensing requirements.
| "dev": true, | ||
| "inBundle": true, | ||
| "license": "ISC" | ||
| "license": "BlueOak-1.0.0", |
There was a problem hiding this comment.
| "dev": true, | ||
| "inBundle": true, | ||
| "license": "ISC", | ||
| "license": "BlueOak-1.0.0", |
Description
Update release workflow to use tested publishing instead of the NPM_TOKEN which is deprecated.
Contributor
Committer
In most cases, this should be a different person than the contributor.