Skip to content

fix: resolve even-numbered backtick precedence issue (#3776) #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UziTech merged 8 commits into from
Oct 17, 2025
+29 −1
Merged

fix: resolve even-numbered backtick precedence issue (#3776) #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b65b9bf
fix: resolve even-numbered backtick precedence issue (#3776)
sanki92 Oct 5, 2025
7a38751
refactor: address gemini-code-assist review feedback
sanki92 Oct 5, 2025
0dacbf4
Address UziTech's feedback: use edit method, preserve Lexer order, mo…
sanki92 Oct 5, 2025
69a1966
fix: resolve ReDoS vulnerability in blockSkip regex pattern
sanki92 Oct 7, 2025
a9d2df7
fix: correct blockSkip pattern to handle mismatched backticks properly
sanki92 Oct 12, 2025
1c8089b
fix: update regex pattern and add test case
sanki92 Oct 14, 2025
5348c18
Merge branch 'master' into fix-issue-3776-backtick-precedence
sanki92 Oct 14, 2025
6b5144c
fix: update blockSkip regex
sanki92 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ const _punctuationOrSpaceGfmStrongEm = /(?!~)[\s\p{P}\p{S}]/u;
const _notPunctuationOrSpaceGfmStrongEm = /(?:[^\s\p{P}\p{S}]|~)/u;

// sequences em should skip over [title](link), `code`, <html>
const blockSkip = /\[(?:[^\[\]`]|`[^`]*?`)*?\]\((?:\\[\s\S]|[^\\\(\)]|\((?:\\[\s\S]|[^\\\(\)])*\))*\)|`[^`]*?`|<(?! )[^<>]*?>/g;
const blockSkip = edit(/\[(?:[^\[\]`]|`[^`]*?`)*?\]\((?:\\[\s\S]|[^\\\(\)]|\((?:\\[\s\S]|[^\\\(\)])*\))*\)|codePattern|<(?! )[^<>]*?>/, 'g')
.replace('codePattern', /(?<!`)(`+)[^`]+\1(?!`)/)
.getRegex();

const emStrongLDelimCore = /^(?:\*+(?:((?!\*)punct)|[^\s*]))|^_+(?:((?!_)punct)|([^\s_]))/;

Expand Down
9 changes: 9 additions & 0 deletions test/specs/new/issue_3776_backtick_precedence.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<p>**You might think this should be bold, but: <code>**</code></p>
<p>**You might think this should be bold, but: <code>**</code></p>
<p>**You might think this should be bold, but: <code>**</code></p>
<p>**You might think this should be bold, but: <code>**</code></p>
<p><strong>This should be bold</strong> and <code>this should be code</code></p>
<p><strong>start <code>contains **</code> end</strong></p>
<p><strong>This should be bold ``</strong>`</p>
<p><strong>This should be bold `</strong>``</p>
<p><strong>start <code>contains **</code> end</strong></p>
17 changes: 17 additions & 0 deletions test/specs/new/issue_3776_backtick_precedence.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
**You might think this should be bold, but: `**`

**You might think this should be bold, but: ``**``

**You might think this should be bold, but: ```**```

**You might think this should be bold, but: ````**````

**This should be bold** and `this should be code`

**start `contains **` end**

**This should be bold ``**`

**This should be bold `**``

**start ``contains **`` end**