Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table ending in empty cell #357

Closed

Conversation

drscannell
Copy link

Currently, if the last cell of a table is empty, it will be dropped from the HTML:

| Header 1 | Header 2 |
|----------|----------|
| Cell 1   | Cell 2   |
| Cell 3   |          |

This pull request does the following:

  1. Add test for situation described above
  2. Fix bug causing the the last cell to not be added during conversion to HTML.

@rhiokim
Copy link

rhiokim commented Mar 4, 2014

+1

@prust
Copy link

prust commented May 13, 2014

+1, also reported in #188

prust added a commit to CSNW/marked that referenced this pull request May 13, 2014
@utensil
Copy link

utensil commented May 25, 2014

+1

@benelog
Copy link

benelog commented Aug 24, 2016

👍

@MaXFalstein
Copy link

Is there any reason why this pull request has not been merged?

@redfast00
Copy link

+1, there is another PR for the same bug in #697

@JoshuaKGoldberg
Copy link

Ping @chjj

@joshbruce
Copy link
Member

#980

@joshbruce joshbruce added this to the 0.4.0 - No known defects milestone Dec 25, 2017
@joshbruce joshbruce removed this from the 0.4.0 - No known defects milestone Apr 4, 2018
@styfle
Copy link
Member

styfle commented Jul 10, 2018

Thanks for the PR but this is already fixed.
See the demo to see it working in the latest version of marked.

@styfle styfle closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants